[ShadCN]: Migrate Simulator WalletHome#14806
Merged
pettinarip merged 20 commits intoFeb 10, 2025
Merged
Conversation
TylerAPfledderer
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
approved these changes
Feb 5, 2025
pettinarip
left a comment
pettinarip
left a comment
Member
There was a problem hiding this comment.
@TylerAPfledderer looks good! left a comment in Chromatic about merging some stories.
re: icons, are you planning to create a separate PR just for their migration?
Contributor
Author
|
@pettinarip provided a response to your comments in Chromatic Regarding the icons, that is correct |
Contributor
Author
|
@pettinarip I condensed the stories down to just a set for However, Chromatic is throwing an error for an unrecognized file path alias that I can not find. 🤔 |
Member
|
@TylerAPfledderer there was a missing image that was breaking the dev branch fixed in #14837. Please update your branch |
Contributor
Author
|
@pettinarip updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the Simulator
WalletHomecomponents to ShadCN/Tailwind.Adds set of stories for the main
WalletHomecomponent.Related Issue
ShadCN Migration